Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for non-canonical URL being sent for product recaching #13

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix for non-canonical URL being sent for product recaching #13

merged 2 commits into from
Jan 8, 2024

Conversation

ryanjehan-aligent
Copy link
Contributor

Fix for non-canonical URL being sent for product recaching

Link: #12

  • Created a store configuration to enable/disable the recaching of the non-canonical product URLs.
  • Updated the GetUrlsForProducts to fetch URL collection using UrlFinder.
  • Updated the URL collection logic to ignore the non-canonical product URLs, if the setting store configuration is enabled and product URL metadata is NULL.

quangdo-aligent
quangdo-aligent requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@quangdo-aligent quangdo-aligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes

Model/Url/GetUrlsForProducts.php Outdated Show resolved Hide resolved
Helper/Config.php Outdated Show resolved Hide resolved
Helper/Config.php Show resolved Hide resolved
@quangdo-aligent quangdo-aligent merged commit 6ba80fb into main Jan 8, 2024
1 check failed
@jehanben jehanben mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quangdo-aligent quangdo-aligent quangdo-aligent approved these changes

@aligent-lturner aligent-lturner Awaiting requested review from aligent-lturner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanjehan-aligent @quangdo-aligent